Android 1.6: "android.view.WindowManager$BadTokenException: Unable to add window — token null is not for an application" – Dev

The best answers to the question “Android 1.6: "android.view.WindowManager$BadTokenException: Unable to add window — token null is not for an application"” in the category Dev.

QUESTION:

I’m trying to open a dialog window, but every time I try to open it it throws this exception:

Uncaught handler: thread main exiting due to uncaught exception
android.view.WindowManager$BadTokenException: 
     Unable to add window -- token null is not for an application
  at android.view.ViewRoot.setView(ViewRoot.java:460)
  at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:177)
  at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:91)
  at android.app.Dialog.show(Dialog.java:238)
  at android.app.Activity.showDialog(Activity.java:2413)

I’m creating it by calling showDialog with the display’s id. The onCreateDialog handler logs fine and I can step through it without an issue, but I’ve attached it since it seems like I’m missing something:

@Override
public Dialog onCreateDialog(int id)
{
    Dialog dialog;
    Context appContext = this.getApplicationContext();
    switch(id)
    {
        case RENAME_DIALOG_ID:
            Log.i("Edit", "Creating rename dialog...");
            dialog = new Dialog(appContext);
            dialog.setContentView(R.layout.rename);
            dialog.setTitle("Rename " + noteName);
            break;
        default:
            dialog = null;
            break;
    }
    return dialog;      
}

Is there something missing from this? Some questions have talked about having this problem when creating a dialog from onCreate, which happens because the activity isn’t created yet, but this is coming from a call from a menu object, and the appContext variable seems like it is correctly populated in the debugger.

ANSWER:

You cannot display an application window/dialog through a Context that is not an Activity. Try passing a valid activity reference

ANSWER:

Instead of :
Context appContext = this.getApplicationContext();
you should use a pointer to the activity you’re in (probably this).

I got bitten by this today too, the annoying part is the getApplicationContext() is verbatim from developer.android.com 🙁

ANSWER:

Android documents suggests to use getApplicationContext();

but it will not work instead of that use your current activity while instantiating AlertDialog.Builder or AlertDialog or Dialog…

Ex:

AlertDialog.Builder builder = new  AlertDialog.Builder(this);

or

AlertDialog.Builder builder = new  AlertDialog.Builder((Your Activity).this);

ANSWER:

Ditto on the getApplicationContext thing.

The documents on the android site says to use it, but it doesn’t work…grrrrr 😛

Just do:

dialog = new Dialog(this); 

“this” is usually your Activity from which you start the dialog.